Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-catalog: Add some tests #16

Merged
merged 4 commits into from
Oct 25, 2023
Merged

app-catalog: Add some tests #16

merged 4 commits into from
Oct 25, 2023

Conversation

illume
Copy link
Contributor

@illume illume commented Oct 24, 2023

This adds a couple of basic storybook stories, and enables tests on the plugins repo.

  • npm run test
  • npm run storybook
  • note the tests are running in the github action

@illume illume marked this pull request as draft October 24, 2023 08:31
@illume illume force-pushed the app-catalog-tests branch 5 times, most recently from 6f681be to 31c184e Compare October 24, 2023 14:40
Signed-off-by: René Dudfield <[email protected]>
@illume illume force-pushed the app-catalog-tests branch from 31c184e to 4c7a362 Compare October 24, 2023 15:43
@illume illume force-pushed the app-catalog-tests branch 4 times, most recently from a275a27 to 7621370 Compare October 24, 2023 18:03
@illume illume marked this pull request as ready for review October 24, 2023 18:10
@illume illume force-pushed the app-catalog-tests branch from 7621370 to e1ee77e Compare October 25, 2023 06:56
@illume illume requested a review from ashu8912 October 25, 2023 08:09
Copy link
Member

@ashu8912 ashu8912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@illume
Copy link
Contributor Author

illume commented Oct 25, 2023

Thanks @ashu8912

@illume illume merged commit 444f80a into main Oct 25, 2023
@illume illume deleted the app-catalog-tests branch October 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants