plugin: Init prometheus plugin #14

yolossn · 2023-10-09T11:23:11Z

Tasks:

Add charts
Add a skeleton (placeholder chart + text informing the user about how to get the chart working)
Add a chart visibility toggle button
Remember user settings (what chart was enabled last time + whether it's visible or not)
Review colors

prometheus/src/chart.tsx

prometheus/src/common.tsx

prometheus/src/index.tsx

prometheus/src/request.tsx

joaquimrocha

Thanks. Here is the review with a few things we had discussed in the call.

prometheus/src/chart.tsx

prometheus/src/common.tsx

prometheus/src/request.tsx

prometheus/src/chart.tsx

prometheus/job.yaml

prometheus/src/common.tsx

Signed-off-by: yolossn <[email protected]>

We have gotten the design indication that there should be a chart skeleton to incite users to enable prometheus, as well as a toggle button to hide/show the chart. Signed-off-by: Joaquim Rocha <[email protected]>

So far it's just whether it's visible or not. Also refactors the code a bit so we don't have a lot of things mixed up. Signed-off-by: Joaquim Rocha <[email protected]>

This makes it easy for the test suites to pass in a custom mock function Signed-off-by: ashu8192 <[email protected]> Signed-off-by: ashu8192 <[email protected]>

prometheus/src/chart.stories.tsx

joaquimrocha · 2023-11-02T17:44:32Z

prometheus/src/chart.tsx

  plots: Array<{
    query: string;
    name: string;
    fillColor: string;
    strokeColor: string;
    dataProcessor: (data: any) => any[];
  }>;
+  fetchMetrics: (query: object) => Promise<any>;


We should avoid having any types unless we really accept/expect anything.

it is the type of request function return which is itself any

That's... not really what we should expect but let's take it just so we can move on.

Signed-off-by: ashu8192 <[email protected]> Signed-off-by: ashu8192 <[email protected]>

yolossn requested a review from joaquimrocha October 9, 2023 11:23

yolossn force-pushed the prom_metrics_plugin branch 3 times, most recently from 9c2eee2 to 428f5f7 Compare October 9, 2023 11:56

joaquimrocha requested changes Oct 9, 2023

View reviewed changes

yolossn force-pushed the prom_metrics_plugin branch 4 times, most recently from 9b12216 to 43b80e9 Compare October 10, 2023 16:47

yolossn requested a review from joaquimrocha October 11, 2023 11:36

joaquimrocha requested changes Oct 11, 2023

View reviewed changes

yolossn force-pushed the prom_metrics_plugin branch 2 times, most recently from c810b79 to 3989b3f Compare October 12, 2023 03:32

yolossn requested a review from joaquimrocha October 12, 2023 03:34

joaquimrocha requested changes Oct 12, 2023

View reviewed changes

prometheus/src/chart.tsx Outdated Show resolved Hide resolved

prometheus/src/chart.tsx Outdated Show resolved Hide resolved

prometheus/src/chart.tsx Outdated Show resolved Hide resolved

yolossn force-pushed the prom_metrics_plugin branch from 3989b3f to 274c1e0 Compare October 13, 2023 10:46

yolossn requested a review from joaquimrocha October 13, 2023 10:46

joaquimrocha force-pushed the prom_metrics_plugin branch 2 times, most recently from 0bc4145 to 428f5f7 Compare October 13, 2023 17:55

yolossn force-pushed the prom_metrics_plugin branch 5 times, most recently from b294b12 to e30f9ad Compare October 23, 2023 08:45

joaquimrocha requested changes Oct 23, 2023

View reviewed changes

prometheus/src/chart.tsx Outdated Show resolved Hide resolved

prometheus/src/chart.tsx Outdated Show resolved Hide resolved

prometheus/src/chart.tsx Outdated Show resolved Hide resolved

yolossn force-pushed the prom_metrics_plugin branch from e30f9ad to 9fedb39 Compare October 23, 2023 13:13

joaquimrocha force-pushed the prom_metrics_plugin branch from fdf0b88 to 607db26 Compare October 24, 2023 21:03

yolossn force-pushed the prom_metrics_plugin branch 3 times, most recently from c0e7c27 to cd9f1d1 Compare October 26, 2023 10:05

ashu8912 force-pushed the prom_metrics_plugin branch 3 times, most recently from a2b6375 to 5289523 Compare October 29, 2023 13:06

ashu8912 reviewed Nov 2, 2023

View reviewed changes

prometheus/job.yaml Outdated Show resolved Hide resolved

ashu8912 reviewed Nov 2, 2023

View reviewed changes

prometheus/src/common.tsx Outdated Show resolved Hide resolved

yolossn force-pushed the prom_metrics_plugin branch from 5289523 to 5adee22 Compare November 2, 2023 07:45

yolossn and others added 4 commits November 2, 2023 14:58

plugin: Init prometheus plugin

ca642c5

Signed-off-by: yolossn <[email protected]>

prometheus: Add skeleton chart + toggle button

8d244d1

We have gotten the design indication that there should be a chart skeleton to incite users to enable prometheus, as well as a toggle button to hide/show the chart. Signed-off-by: Joaquim Rocha <[email protected]>

prometheus: Store the settings for the plugin

795ec96

So far it's just whether it's visible or not. Also refactors the code a bit so we don't have a lot of things mixed up. Signed-off-by: Joaquim Rocha <[email protected]>

plugin: Allow to pass the fetchChart api function as prop

bd0579d

This makes it easy for the test suites to pass in a custom mock function Signed-off-by: ashu8192 <[email protected]> Signed-off-by: ashu8192 <[email protected]>

yolossn force-pushed the prom_metrics_plugin branch from 5adee22 to b2166a6 Compare November 2, 2023 09:28

joaquimrocha reviewed Nov 2, 2023

View reviewed changes

plugin: Add test for Chart and VisibilityButton component

ebdf0b2

Signed-off-by: ashu8192 <[email protected]> Signed-off-by: ashu8192 <[email protected]>

ashu8912 force-pushed the prom_metrics_plugin branch from b2166a6 to ebdf0b2 Compare November 3, 2023 14:30

joaquimrocha merged commit 282dd8a into main Nov 3, 2023
2 checks passed

joaquimrocha deleted the prom_metrics_plugin branch November 3, 2023 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plugin: Init prometheus plugin #14

plugin: Init prometheus plugin #14

yolossn commented Oct 9, 2023 •

edited

Loading

joaquimrocha left a comment

joaquimrocha Nov 2, 2023

ashu8912 Nov 3, 2023

joaquimrocha Nov 3, 2023

plugin: Init prometheus plugin #14

plugin: Init prometheus plugin #14

Conversation

yolossn commented Oct 9, 2023 • edited Loading

joaquimrocha left a comment

Choose a reason for hiding this comment

joaquimrocha Nov 2, 2023

Choose a reason for hiding this comment

ashu8912 Nov 3, 2023

Choose a reason for hiding this comment

joaquimrocha Nov 3, 2023

Choose a reason for hiding this comment

yolossn commented Oct 9, 2023 •

edited

Loading