frontend: Use ISO format for dates tests #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node has changes how they format the dates when using "toLocaleString", introducing a special character (U+202f) instead of a space. Our first instinct was to lower the Node version and wait for a fix, but according to [1], Node doesn't seem to be reverting it soon and mentions one shouldn't use localized strings for testing... So, in order to avoid this, this patch makes the dates show up in ISO format. [1] nodejs/node#46123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has changes how they format the dates when using "toLocaleString",
introducing a special character (U+202f) instead of a space.
Our first instinct was to lower the Node version and wait for a fix,
but according to [1], Node doesn't seem to be reverting it soon and
mentions one shouldn't use localized strings for testing...
So, in order to avoid this, this patch makes the dates show up in
ISO format.
[1] nodejs/node#46123