frontend: Add notistack to pluginLib object #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary solution to handle an issue in notistack, notistack has a peer dependency on material-ui and thus seperating notistack and using it as a dependency in the plugin development will mean having material-ui also installed in the plugin development, but we already pass material-ui via the pluginObj so it doesn't makes sense to have all the peer dependency(specially material-ui) for notistack in the plugin development as well.
joaquimrocha
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution for now until we have something solid either from notistack or we have a better approach of handling peer dependency of plugin packages
iamhosseindhv/notistack#335
iamhosseindhv/notistack#421