frontend: KubeObject: Set missing attributes in attrs #2654
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
farodin91
reviewed
Dec 10, 2024
skoeva
changed the title
skoeva
force-pushed
the
row-action-bugs
branch
from
e7d7491 to
e7e9a0c
Compare
sniok
reviewed
Dec 11, 2024
skoeva
force-pushed
the
row-action-bugs
branch
2 times, most recently
from
ed8e076 to
2150ef0
Compare
Previously, the apiVersion was not being provided in the jsonData object in the resource table, and apiVersion is necessary for authenticating and displaying valid row actions. This change ensures that resource, group, and version are always provided to ensure that valid row actions for the given KubeObject are visible. Fixes: #2633 Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva
force-pushed
the
row-action-bugs
branch
from
2150ef0 to
f86d8b4
Compare
skoeva
changed the title
sniok
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the apiVersion was not being provided in the jsonData object in the resource table, and apiVersion is necessary for authenticating and displaying valid row actions. This change ensures that resource, group, and version are always provided to ensure that valid row actions for the given KubeObject are visible.
Fixes: #2633
Testing