Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Improve Table performance and update styles #2620

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Nov 29, 2024

This PR optimizes Table to avoid rerenders when data is not changed

Testing

Dev mode without react/redux extensions (incognito mode)

Switching between pods <-> deployments pages (all lists are already loaded)

Before
Average duration ~240ms
image

Average duration ~150 ms
image

So approximately x1.6 faster

@sniok sniok added frontend Issues related to the frontend performance labels Nov 29, 2024
@sniok sniok force-pushed the table-perf branch 4 times, most recently from f435c0e to 6049d76 Compare December 3, 2024 16:19
@sniok sniok marked this pull request as ready for review December 3, 2024 16:19
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@sniok sniok merged commit 45c3b59 into main Dec 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer performance size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants