Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Add missing isNamespaced property to Custom Resource class #2617

Merged
merged 1 commit into from
Dec 6, 2024
Merged

frontend: Add missing isNamespaced property to Custom Resource class #2617

merged 1 commit into from
Dec 6, 2024

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Nov 28, 2024 •
edited
Loading

Fixes a regression introduced in #1967 where namespaced scope was left out when creating Custom Resource class.

Fixes #2613

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@sniok sniok requested a review from a team November 28, 2024 09:58
@sniok sniok added frontend Issues related to the frontend regression Bugs for things that used to work in previous releases. labels Nov 29, 2024
@sniok
Copy link
Contributor Author

sniok commented Dec 3, 2024

@headlamp-k8s/devs pls review

skoeva
skoeva approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

farodin91
farodin91 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@farodin91 farodin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sniok This is great it also fix an issue during deletion of custom resources.

@joaquimrocha joaquimrocha merged commit 81b37f7 into main Dec 6, 2024
17 of 18 checks passed
@joaquimrocha joaquimrocha deleted the crd-namespaced-fix branch December 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farodin91 farodin91 farodin91 approved these changes

@skoeva skoeva skoeva approved these changes

Assignees
No one assigned
Labels
frontend Issues related to the frontend regression Bugs for things that used to work in previous releases. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useList not filtering by namespace on CRDs
4 participants
@sniok @farodin91 @skoeva @joaquimrocha