Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Node: Fix table columns and empty values #2604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Nov 22, 2024

This change adjusts the width of the table columns to prevent UI issues and fills in empty values where applicable.

Fixes: #2100

Testing

  • Open Headlamp in cluster and navigate to the Nodes page
  • Ensure that all empty fields are filled with "None" and columns with the info icon have sufficient spacing.

image

@skoeva skoeva added frontend Issues related to the frontend Table Table component issues labels Nov 22, 2024
@skoeva skoeva requested a review from a team November 22, 2024 21:39
@skoeva skoeva self-assigned this Nov 22, 2024
@skoeva skoeva linked an issue Nov 22, 2024 that may be closed by this pull request
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 22, 2024
@@ -26,6 +26,7 @@ export default function NodeList() {
{
id: 'cpu',
label: t('CPU'),
gridTemplate: 'minmax(120px, .5fr)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise we get this in the UI (described in the issue):

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try gridTremplate: 'min-content'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to look very similar, made the change here for simplicity

frontend/src/components/node/List.tsx Outdated Show resolved Hide resolved
This change adjusts the width of the table columns to prevent UI issues
and fills in empty values where applicable.

Fixes: #2100

Signed-off-by: Evangelos Skopelitis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend size:S This PR changes 10-29 lines, ignoring generated files. Table Table component issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodes table looks cut off
2 participants