frontend: Rewrite useQueryParamsState logic and add unit tests #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Comment on lines
26
to
28
| if (initialState) { | ||
| return initialState; | ||
| } |
There was a problem hiding this comment.
AFAIU, if the initialState is valid, this logic will never actually get the param from the URL if it has an initialState. Is this intended?
Shouldn't we keep the whole logic but return the initialState instead of undefined at the end of this function?
There was a problem hiding this comment.
I've just retested it and namespace default grouping is not working properly. returning initialState at the end instead of undefined doesn't work because there's a useEffect that updates the value from existing url state. I need to rethink this logic more
There was a problem hiding this comment.
rewrote the logic to get rid of useState and it's so much simpler now. also added unit tests
Signed-off-by: Oleksandr Dubenko <[email protected]>
sniok
force-pushed
the
map-query-state-fix
branch
from
787c9b3
to
e725138
Compare
dosubot
bot
added
size:L
sniok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Go to map
Select a node
Refresh the page
Node should still be selected
Before this fix it wouldn't work