-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: add default actions to ResourceListView #2044
frontend: add default actions to ResourceListView #2044
Conversation
@joaquimrocha What do you think of this idea? I could try to merge details and list actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible changes @farodin91 ! Thanks a lot.
I left some comments which I believe will improve the code. I also noticed that the menu options partially outside the view. Not sure if you can e.g. render the menu with the anchor being the top right to avoid this.
Also. Once the review is approved, I think it would make sense to have the commits separated a bit. At least in 2: 1. Add actions capability to tables; 2. Add the view/edit/delete context actions to resource tables
frontend/src/components/common/ActionMenuItem/ActionMenuItem.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/common/ActionMenuItem/ActionMenuItem.tsx
Outdated
Show resolved
Hide resolved
89b7e73
to
1808383
Compare
i used the inhouse method to render the menu. |
1808383
to
94c6cc6
Compare
@joaquimrocha I updated a lot of thinks. What do you think? |
0edb762
to
b03c542
Compare
Signed-off-by: farodin91 <[email protected]>
b03c542
to
40f8c20
Compare
@joaquimrocha @illume Would you like to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks.
I tested it, and it's a really nice improvement.
@farodin91 Another great PR! Thanks a lot, and keep those coming. About this one, I think it's great as it is, but if we could hide the view button when the edit button is enabled (as its done through the AuthVisible comp in the details view), that would be more consistent. |
Now the actions can be used from the list views (by clicking the action ... to bring up a menu) as well as on the detail view.