Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx gallery issue #601

Merged
merged 3 commits into from
May 11, 2021
Merged

Fix sphinx gallery issue #601

merged 3 commits into from
May 11, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented May 11, 2021

Motivation

Fix #600.
Also update h5py intersphinx URL.
Removing 'download_section_examples'=False seems to not do anything, even after adding sections. Apparently this feature was removed some time ago but the docs never updated: sphinx-gallery/sphinx-gallery#376

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
    Where 'download_section_examples' is now an unknown key. Fix Add support for Sphinx 4 #600.

@rly rly requested a review from a team May 11, 2021 17:51
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #601 (86cfb2e) into dev (fcd52c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #601   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files          41       41           
  Lines        8207     8207           
  Branches     1765     1765           
=======================================
  Hits         7067     7067           
  Misses        810      810           
  Partials      330      330           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd52c0...86cfb2e. Read the comment docs.

@rly rly merged commit 8493f96 into dev May 11, 2021
@rly rly deleted the fix/sphinx_gallery branch May 11, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Sphinx 4
2 participants