Revert "Validation finds unexpected elements (#542)" #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#542 introduced warnings for extra fields but treats attributes added to a spec as extra fields. This is problematic for PyNWB because in the NWB schema, the
Unitstable contains the column with specname: spike_times; neurodata_type_inc: VectorData; attributes: [new attribute for resolution]. The resolution attribute is flagged as an extra field. Upon further discussion at hdmf-dev/hdmf-schema-language#13 , we decided to continue allowing this case (this use case may also appear in extensions).This means that #542 as is will break validation of NWB files with the Units/spike_times.resolution field (and files with extensions that have this case). @dsleiter has graciously agreed to work on resolving this issue in a separate PR. In the meantime, in order to prepare for the upcoming 2.5 minor release, this PR reverts commit 67cffec (#542).
We will reintroduce this commit in a separate PR post-release.