Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated actions in deploy and release yaml #165

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Feb 14, 2024

Motivation

The Deploy and release workflow is out-of-date with node version requirements

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d93c0f) 86.04% compared to head (cec93b5) 86.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #165   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files           5        5           
  Lines        1161     1161           
  Branches      296      296           
=======================================
  Hits          999      999           
  Misses        107      107           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel marked this pull request as ready for review February 14, 2024 00:20
CHANGELOG.md Outdated Show resolved Hide resolved
stephprince
stephprince previously approved these changes Feb 14, 2024
Co-authored-by: Steph Prince <[email protected]>
@oruebel
Copy link
Contributor Author

oruebel commented Feb 14, 2024

@stephprince can you reapprove. I committed your suggested change to the CHANGELOG which automatically rejected your previous review.

@oruebel oruebel merged commit cc1fcbc into dev Feb 14, 2024
24 checks passed
@oruebel oruebel deleted the up/deploy_release_versions branch February 14, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants