-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openroad-gui: add OpenROAD
build with GUI
option
#228
Conversation
@joennlae Thanks for your contribution! We had discussions on #193 (comment) on the differentiation between the package in this repository and the the one in conda-forge. I'm curious if you'd be open to create a similar PR against https://github.com/conda-forge/staged-recipes and put me as a co-maintainer? If we also want to keep the recipe in this repo, I think it might be better to have it as a package variant |
@proppy I completely get your point.
|
I think we could have the
Good point, we'd need to convince them to tag more version; one thing we discussed before with them was to tag things similar to the verible repo: https://github.com/chipsalliance/verible/tags
I think that would also be a proble with conda-eda, I was under the impression that all of OpenROAD was under BSD-3 if that's not the case we should update https://github.com/hdl/conda-eda/blob/master/pnr/openroad/meta.yaml#L60
conda-forge has some automation to bump packages everytime there is a release, see for e.g: |
Ok. If you help me move forward on the |
@joennlae sorry for the late reply.
Would it be OK for us to re-submit your work here as a package on https://github.com/conda-forge/staged-recipes and add us both as co-maintainers?
Let me know if you have any questions, also happy to send a PR against your branch to get this started. |
Started a discussion around this here: |
/cc @xobs |
a5a7103
to
f882260
Compare
build failing trying to find
|
curious why an older version |
@xobs skipped the ui for now on osx, does this look good to you? |
Auditing the warning from the error logs:
seems safe to ignore since it's just about cleaning up the rpath.
safe to ignore per @ajelinski in #165 (comment)
should probably remove readline from the |
Looks good to me! I'll test it once it's merged and see how difficult it would be to at least build on my local osx-arm64 machine. |
found another warning:
|
the
|
merging since build are passing on both platforms. |
Thank you for this excellent repo 💯 . It saved me a ton of time 👍
This PR adds a GUI-supported build for
OpenROAD
. This build is tested and can be installed viaconda
: