produce valid xml for null-byte in test name #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solve #468.
A parameterized test name can be anything, and it can even include the null-byte.
It seems that the null-byte is not part of the valid character range for xml (see Character Range in xml), so we can not encode it. But nothing prevents us from representing it somehow, and this is what is proposed here.
With this PR, when we need to represent a null-byte in xml, we output
\0
instead. This is not perfect, reversible, a parser would not return a null-byte when reading\0
, but I believe it to be good enough for reports generation.