Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

produce valid xml for null-byte in test name #477

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

maxgabut
Copy link
Collaborator

@maxgabut maxgabut commented Jun 5, 2018

This solve #468.

A parameterized test name can be anything, and it can even include the null-byte.

It seems that the null-byte is not part of the valid character range for xml (see Character Range in xml), so we can not encode it. But nothing prevents us from representing it somehow, and this is what is proposed here.

With this PR, when we need to represent a null-byte in xml, we output \0 instead. This is not perfect, reversible, a parser would not return a null-byte when reading \0, but I believe it to be good enough for reports generation.

@hcoles
Copy link
Owner

hcoles commented Jun 6, 2018

Thanks!

@maxgabut maxgabut deleted the valid-xml-on-null-byte branch June 7, 2018 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants