-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an additional report-aggregate mojo #433
Conversation
@rchargel Thanks for looking at the (long awaiting) feature. One high level question from the person maintaining the Gradle plugin for PIT. Does that code have to be Maven dependent? Having it implemented in PIT itself would make it easier to reuse in Gradle/Sbt/Ant/... |
I can look at moving it out to one of the other modules after the holiday.
…On Dec 16, 2017 16:59, "Marcin Zajączkowski" ***@***.***> wrote:
@rchargel <https://github.com/rchargel> Thanks for looking at the (long
awaiting) feature. One high level question from the person maintaining the
Gradle plugin for PIT. Does that code have to be Maven dependent? Having it
implemented in PIT itself would make it easier to reuse in
Gradle/Sbt/Ant/...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#433 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC_EbgJbMwijHiAI0fiNdZvZ4cgkZJW7ks5tBD0kgaJpZM4RD9rh>
.
|
…he jacoco mojo of the same name
…ld potentially be used by non-maven users
51f0706
to
80cf914
Compare
@szpak and @hcoles As per the request above, I updated the PR to separate out the aggregation code into a separate module (pitest-aggregator). That module has one important class, ReportAggregator with a builder. The builder is provided with a list of source directories, compiled code directories, and the mutations and linecoverage XML files, and then the aggregator can build an aggregated version of the report. The "report-aggregate" maven goal now just calls into the code above. This change would be very useful to my organization as most of our maven builds are separated into 10 or more sub-modules. Thank you, |
@rchargel Thanks for the PR - I've not had chance to look at it yet (sorry), but I should finally have some time this weekend. |
Finally merged - sorry for the delay |
@rchargel Could you create a PR against https://github.com/hcoles/pitest-site that adds documentation for the new mojo? |
Sure, I'll try to get to that this week.
…On Jan 30, 2018 16:00, "Henry Coles" ***@***.***> wrote:
@rchargel <https://github.com/rchargel> Could you create a PR against
https://github.com/hcoles/pitest-site that adds documentation for the new
mojo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#433 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC_EbgSxlFflcvMA48dNXfaqmN6MyZ-Aks5tP4LdgaJpZM4RD9rh>
.
|
@rchargel Hello, I've trouble to use your plugin, have you a sample somewere? |
Yes, I owe some documentation. I'll put that together this week.
…On Sat, Mar 24, 2018, 16:57 sarahBuisson ***@***.***> wrote:
@rchargel <https://github.com/rchargel> Hello, I've trouble to use your
plugin, have you a sample somewere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#433 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC_EbovPv_yszdC1eAakxM40IGjlRFqPks5thrMlgaJpZM4RD9rh>
.
|
Can you write this documentation, or direct me to it. I've tried to generate an aggregate report based off the source code, but it isn't working. |
I have a PR in
…On Tue, Apr 17, 2018 at 6:36 PM, Michael S ***@***.***> wrote:
Can you write this documentation, or direct me to it. I've tried to
generate an aggregate report based off the source code, but it isn't
working.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#433 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC_Ebt5pxicxRA1y8GcZyNGgi09ZbivHks5tpm5fgaJpZM4RD9rh>
.
|
Works similarly to the mojo of the same name from Jacoco.
The idea here is that if you have a multi-module maven project, you can generate individual reports for each of your modules, but then have a "report-aggregation" module which can be used to build a final aggregated report.
The report-aggregation module would have to include the modules it is interested in as dependencies.
As an example, say I have some project called company-functions, that had a few sub-modules:
company-functions
|____ module-1
|____ module-2
A third module would be created, maybe "mutation-report-aggregation" , which has module-1 and module-2 as dependencies.
That mutation-report-aggregation module would use the report-aggregate goal for your maven plugin, and an aggregated report would be generated.
The only caveat is that both the Line Coverage report has to have been exported, and an XML formatted formatted version of the mutation report must be present.