Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate environment variables to surefire run #197

Merged
merged 7 commits into from
May 13, 2015
Merged

Conversation

lkwg82
Copy link
Contributor

@lkwg82 lkwg82 commented May 11, 2015

added propagation of environment variables to underlying java processes …
here is an example to pass Xvfb-Display to the pitest runs

                  <plugins>
                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-jar-plugin</artifactId>
                        <executions>
                            <execution>
                                <id>default-jar</id>
                                <phase>never</phase>
                            </execution>
                        </executions>
                    </plugin>

                    <plugin>
                        <groupId>org.codehaus.mojo</groupId>
                        <artifactId>selenium-maven-plugin</artifactId>
                        <version>2.3</version>
                        <executions>
                            <execution>
                                <id>start</id>
                                <phase>pre-integration-test</phase>
                                <goals>
                                    <goal>xvfb</goal>
                                </goals>
                                <configuration>
                                    <background>true</background>
                                    <display>:${xvfb.display}</display>
                                    <options>
                                        <option>-listen</option>
                                        <option>tcp</option>
                                        <option>-port</option>
                                        <option>60${xvfb.display}</option>
                                    </options>
                                </configuration>
                            </execution>
                        </executions>
                    </plugin>

                    <plugin>
                        <groupId>org.pitest</groupId>
                        <artifactId>pitest-maven</artifactId>
                        <version>1.1.6-SNAPSHOT</version>
                        <configuration>
                            <environmentVariables>
                                <DISPLAY>:${xvfb.display}</DISPLAY>
                            </environmentVariables>
                            ...
                        </configuration>
                        <executions>
                            <execution>
                                <phase>integration-test</phase>
                                <goals>
                                    <goal>mutationCoverage</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>
                </plugins>

lkwg82 added 6 commits May 11, 2015 11:08
here is an example to pass Xvfb-Display to the pitest runs
```
                  <plugins>
                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-jar-plugin</artifactId>
                        <executions>
                            <execution>
                                <id>default-jar</id>
                                <phase>never</phase>
                            </execution>
                        </executions>
                    </plugin>

                    <plugin>
                        <groupId>org.codehaus.mojo</groupId>
                        <artifactId>selenium-maven-plugin</artifactId>
                        <version>2.3</version>
                        <executions>
                            <execution>
                                <id>start</id>
                                <phase>pre-integration-test</phase>
                                <goals>
                                    <goal>xvfb</goal>
                                </goals>
                                <configuration>
                                    <background>true</background>
                                    <display>:${xvfb.display}</display>
                                    <options>
                                        <option>-listen</option>
                                        <option>tcp</option>
                                        <option>-port</option>
                                        <option>60${xvfb.display}</option>
                                    </options>
                                </configuration>
                            </execution>
                        </executions>
                    </plugin>

                    <plugin>
                        <groupId>org.pitest</groupId>
                        <artifactId>pitest-maven</artifactId>
                        <version>1.1.6-SNAPSHOT</version>
                        <configuration>
                            <environmentVariables>
                                <DISPLAY>:${xvfb.display}</DISPLAY>
                            </environmentVariables>
                            ...
                        </configuration>
                        <executions>
                            <execution>
                                <phase>integration-test</phase>
                                <goals>
                                    <goal>mutationCoverage</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>
                </plugins>
```
@hcoles
Copy link
Owner

hcoles commented May 12, 2015

@lkwg82 Thanks for this - the tests look to be failing due to mixed use of matchers and value with mockito.

I wonder how this should interact with the surefire integration introduced in #173?

Should the environment variables explicitly set in the pitest config overwrite those in surefire, or be appended to them?

@lkwg82
Copy link
Contributor Author

lkwg82 commented May 12, 2015

Fixed it. I ran out of time yesterday and missed it.

@hcoles hcoles merged commit 2c05240 into hcoles:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants