-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate environment variables to surefire run #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
here is an example to pass Xvfb-Display to the pitest runs ``` <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-jar-plugin</artifactId> <executions> <execution> <id>default-jar</id> <phase>never</phase> </execution> </executions> </plugin> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>selenium-maven-plugin</artifactId> <version>2.3</version> <executions> <execution> <id>start</id> <phase>pre-integration-test</phase> <goals> <goal>xvfb</goal> </goals> <configuration> <background>true</background> <display>:${xvfb.display}</display> <options> <option>-listen</option> <option>tcp</option> <option>-port</option> <option>60${xvfb.display}</option> </options> </configuration> </execution> </executions> </plugin> <plugin> <groupId>org.pitest</groupId> <artifactId>pitest-maven</artifactId> <version>1.1.6-SNAPSHOT</version> <configuration> <environmentVariables> <DISPLAY>:${xvfb.display}</DISPLAY> </environmentVariables> ... </configuration> <executions> <execution> <phase>integration-test</phase> <goals> <goal>mutationCoverage</goal> </goals> </execution> </executions> </plugin> </plugins> ```
@lkwg82 Thanks for this - the tests look to be failing due to mixed use of matchers and value with mockito. I wonder how this should interact with the surefire integration introduced in #173? Should the environment variables explicitly set in the pitest config overwrite those in surefire, or be appended to them? |
Fixed it. I ran out of time yesterday and missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added propagation of environment variables to underlying java processes …
here is an example to pass Xvfb-Display to the pitest runs