Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter try-with-resources before filtering inlined code again #1219

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented May 25, 2023

Due to the changes in 1ceafb3, the issue in #681 that was fixed in #683 is back.
As the order of filters is no longer defined by the service loader file order,
but by name, the try-with-resources filter was put last and thus after the inlined code filter again.
This made the same issue reappear.

This PR adds an explicit order setting for features on which they are compared first and only for equal ones by name.
Standard value is 100 for all features, to prevent the psychologically bad necessity to use a negative order.
The try-with-resources filter gets 50, so it is executed before the inlined code filter which is the important part.

@Vampire Vampire force-pushed the filter-try-with-resources-before-filtering-inlined-code-again branch from c5b5f57 to e38fd83 Compare May 25, 2023 02:12
@hcoles
Copy link
Owner

hcoles commented May 25, 2023

Good catch and good soloution. Thanks.

@hcoles hcoles merged commit 9edac2a into hcoles:master May 25, 2023
@Vampire Vampire deleted the filter-try-with-resources-before-filtering-inlined-code-again branch May 25, 2023 08:05
@Vampire
Copy link
Contributor Author

Vampire commented May 25, 2023

Thanks for adding the test. I was in a hurry and too lazy yesterday. :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants