Remove -Werror for 32-bit

hcho3 · Jan 31, 2024 · c652bc6 · c652bc6
1 parent b9949ad
commit c652bc6
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 25 deletions.
diff --git a/.github/workflows/i386.yml b/.github/workflows/i386.yml
@@ -33,4 +33,7 @@ jobs:
         cache-to: type=gha,mode=max
     - name: Build XGBoost
       run: |
-        docker run --rm -v $PWD:/workspace -w /workspace localhost:5000/xgboost/build-32bit:latest tests/ci_build/build_via_cmake.sh
+        docker run --rm -v $PWD:/workspace -w /workspace \
+          localhost:5000/xgboost/build-32bit:latest \
+          tests/ci_build/build_via_cmake.sh \
+          -DCMAKE_COMPILE_WARNING_AS_ERROR=OFF
diff --git a/tests/buildkite/build-cpu-arm64.sh b/tests/buildkite/build-cpu-arm64.sh
@@ -12,7 +12,7 @@ command_wrapper="tests/ci_build/ci_build.sh aarch64"
 
 echo "--- Build libxgboost from the source"
 $command_wrapper tests/ci_build/build_via_cmake.sh --conda-env=aarch64_test \
-  -DUSE_OPENMP=ON -DHIDE_CXX_SYMBOL=ON
+  -DUSE_OPENMP=ON -DHIDE_CXX_SYMBOL=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 echo "--- Run Google Test"
 $command_wrapper bash -c "cd build && ctest --extra-verbose"
 

diff --git a/tests/buildkite/build-cpu.sh b/tests/buildkite/build-cpu.sh
@@ -15,7 +15,7 @@ $command_wrapper rm -fv dmlc-core/include/dmlc/build_config_default.h
   # include/dmlc/build_config_default.h.
 echo "--- Build libxgboost from the source"
 $command_wrapper tests/ci_build/build_via_cmake.sh -DCMAKE_PREFIX_PATH=/opt/grpc \
-		 -DPLUGIN_FEDERATED=ON
+     -DPLUGIN_FEDERATED=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 echo "--- Run Google Test"
 $command_wrapper bash -c "cd build && ctest --extra-verbose"
 echo "--- Stash XGBoost CLI executable"
@@ -25,7 +25,8 @@ buildkite-agent artifact upload ./xgboost
 echo "--- Run Google Test with sanitizer enabled"
 $command_wrapper tests/ci_build/build_via_cmake.sh -DUSE_SANITIZER=ON \
   -DENABLED_SANITIZERS="address;leak;undefined" -DCMAKE_BUILD_TYPE=Debug \
-  -DSANITIZER_PATH=/usr/lib/x86_64-linux-gnu/
+  -DSANITIZER_PATH=/usr/lib/x86_64-linux-gnu/ \
+  -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 CI_DOCKER_EXTRA_PARAMS_INIT="-e ASAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer "`
   `"-e ASAN_OPTIONS=symbolize=1 "`
   `"-e UBSAN_OPTIONS=print_stacktrace=1:log_path=ubsan_error.log "`

diff --git a/tests/buildkite/build-cuda-with-rmm.sh b/tests/buildkite/build-cuda-with-rmm.sh
@@ -22,16 +22,17 @@ command_wrapper="tests/ci_build/ci_build.sh gpu_build_centos7 --build-arg "`
 
 echo "--- Build libxgboost from the source"
 $command_wrapper tests/ci_build/build_via_cmake.sh \
-		 -DCMAKE_PREFIX_PATH="/opt/grpc;/opt/rmm" \
-		 -DUSE_CUDA=ON \
-		 -DUSE_OPENMP=ON \
-		 -DHIDE_CXX_SYMBOLS=ON \
-		 -DPLUGIN_FEDERATED=ON \
-		 -DPLUGIN_RMM=ON \
-		 -DUSE_NCCL=ON \
-		 -DUSE_NCCL_LIB_PATH=ON \
-		 -DNCCL_INCLUDE_DIR=/usr/include \
-		 -DUSE_DLOPEN_NCCL=ON \
+     -DCMAKE_PREFIX_PATH="/opt/grpc;/opt/rmm" \
+     -DUSE_CUDA=ON \
+     -DUSE_OPENMP=ON \
+     -DHIDE_CXX_SYMBOLS=ON \
+     -DPLUGIN_FEDERATED=ON \
+     -DPLUGIN_RMM=ON \
+     -DUSE_NCCL=ON \
+     -DUSE_NCCL_LIB_PATH=ON \
+     -DNCCL_INCLUDE_DIR=/usr/include \
+     -DUSE_DLOPEN_NCCL=ON \
+     -DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
   ${arch_flag}
 echo "--- Build binary wheel"
 $command_wrapper bash -c \

diff --git a/tests/buildkite/build-cuda.sh b/tests/buildkite/build-cuda.sh
@@ -22,16 +22,17 @@ command_wrapper="tests/ci_build/ci_build.sh gpu_build_centos7 --build-arg "`
 
 echo "--- Build libxgboost from the source"
 $command_wrapper tests/ci_build/build_via_cmake.sh \
-		 -DCMAKE_PREFIX_PATH="/opt/grpc" \
-		 -DUSE_CUDA=ON \
-		 -DUSE_OPENMP=ON \
-		 -DHIDE_CXX_SYMBOLS=ON \
-		 -DPLUGIN_FEDERATED=ON \
-		 -DUSE_NCCL=ON \
-		 -DUSE_NCCL_LIB_PATH=ON \
-		 -DNCCL_INCLUDE_DIR=/usr/include \
-		 -DUSE_DLOPEN_NCCL=ON \
-		 ${arch_flag}
+     -DCMAKE_PREFIX_PATH="/opt/grpc" \
+     -DUSE_CUDA=ON \
+     -DUSE_OPENMP=ON \
+     -DHIDE_CXX_SYMBOLS=ON \
+     -DPLUGIN_FEDERATED=ON \
+     -DUSE_NCCL=ON \
+     -DUSE_NCCL_LIB_PATH=ON \
+     -DNCCL_INCLUDE_DIR=/usr/include \
+     -DUSE_DLOPEN_NCCL=ON \
+     -DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
+     ${arch_flag}
 echo "--- Build binary wheel"
 $command_wrapper bash -c \
   "cd python-package && rm -rf dist/* && pip wheel --no-deps -v . --wheel-dir dist/"

diff --git a/tests/ci_build/build_via_cmake.sh b/tests/ci_build/build_via_cmake.sh
@@ -24,7 +24,7 @@ fi
 rm -rf build
 mkdir build
 cd build
-cmake .. ${cmake_args} -DGOOGLE_TEST=ON -DUSE_DMLC_GTEST=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DENABLE_ALL_WARNINGS=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -GNinja ${cmake_prefix_flag} -DHIDE_CXX_SYMBOLS=ON -DBUILD_DEPRECATED_CLI=ON
+cmake .. ${cmake_args} -DGOOGLE_TEST=ON -DUSE_DMLC_GTEST=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DENABLE_ALL_WARNINGS=ON -GNinja ${cmake_prefix_flag} -DHIDE_CXX_SYMBOLS=ON -DBUILD_DEPRECATED_CLI=ON
 ninja clean
 time ninja -v
 cd ..