-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tweaks for EZQMS-1317 #7854
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Victor Ilyushchenko <[email protected]>
Connected to Huly®: UBERF-9330 |
@mr1name could you add screenshots of how it looks for various cases:
|
@mr1name I think what we wanted is a new standalone block so it'd look like Approval Review Author |
@lexiv0re Why? These are foldable blocks that refer to a whole review or approval request. What's the point of making it a separate block? This would simply imply duplicating all blocks with the same meaning in the general case. |
Signed-off-by: Victor Ilyushchenko <[email protected]>
@mr1name the point is to match the expectations where one would like to see three independent signatures for a document from:
The idea is that the author signs the document itself, not a review/approval request. Theoretically, the author's signature could live on it's own w/o any reviews/approvals:
It's just in the system we combine the actions of signing by the author and sending to review/approval. |
At least that was my understanding. We can check with Charles to clarify this before proceeding in any direction. |
Pull Request Requirements: