Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tweaks for EZQMS-1317 #7854

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mr1name
Copy link
Member

@mr1name mr1name commented Jan 31, 2025

Pull Request Requirements:

  • Provide a brief description of the changeset.
  • Include a screenshots if applicable
  • Ensure that the changeset adheres to the DCO guidelines.

Signed-off-by: Victor Ilyushchenko <[email protected]>
@mr1name mr1name requested a review from lexiv0re January 31, 2025 11:58
Copy link

Connected to Huly®: UBERF-9330

@lexiv0re
Copy link
Collaborator

@mr1name could you add screenshots of how it looks for various cases:

  1. only review
  2. only approval
  3. review + approval
  4. review -> draft -> review
  5. review -> draft -> review -> approval

@mr1name
Copy link
Member Author

mr1name commented Jan 31, 2025

It's identical in all these cases just that each review or approval block now has a row with the author and the date (“signature”) of initiation.

Screenshot 2025-01-31 at 15 08 01

@lexiv0re
Copy link
Collaborator

@mr1name I think what we wanted is a new standalone block so it'd look like


Approval
John


Review
Jack


Author
Jane


@mr1name
Copy link
Member Author

mr1name commented Jan 31, 2025

@lexiv0re Why? These are foldable blocks that refer to a whole review or approval request. What's the point of making it a separate block? This would simply imply duplicating all blocks with the same meaning in the general case.

Signed-off-by: Victor Ilyushchenko <[email protected]>
@lexiv0re
Copy link
Collaborator

@mr1name the point is to match the expectations where one would like to see three independent signatures for a document from:

  1. Author
  2. Reviewer
  3. Approver

The idea is that the author signs the document itself, not a review/approval request. Theoretically, the author's signature could live on it's own w/o any reviews/approvals:

  1. Author drafts a document and signs it. -> The signature is there but there's no review/approval yet.
  2. He gives it to a reviewer/approver. -> Only at this point the review/approval process is started.

It's just in the system we combine the actions of signing by the author and sending to review/approval.

@lexiv0re
Copy link
Collaborator

At least that was my understanding. We can check with Charles to clarify this before proceeding in any direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants