Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/handles #231

Merged
merged 9 commits into from
Jun 30, 2020
Merged

Feature/handles #231

merged 9 commits into from
Jun 30, 2020

Conversation

hbldh
Copy link
Owner

@hbldh hbldh commented Jun 30, 2020

Merges #167 by means of new branch.

Changed some details of #167 to handle characteristics a bit differently.
read_gatt_char, write_gatt_char, start_notify and stop_notify now accepts

  • BleakGATTCharacteristics objects
  • integer handler for the characteristic to use
  • string uuid
  • uuid.UUID objects

The efficiency of using the different solutions are in that descending order as well. It is now less effective than before to use string representations of the UUIDs of a characteristic, this is an effect of keeping track of characteristics is done by integer handles instead of string uuids. This will hopefully fix #139 and #159.

@hbldh hbldh added bug Something isn't working enhancement New feature or request Backend: pythonnet Issues or PRs relating to the .NET/pythonnet backend Backend: BlueZ Issues and PRs relating to the BlueZ backend Backend: Core Bluetooth Issues and PRs relating to the Core Bluetooth backend labels Jun 30, 2020
@hbldh hbldh added this to the Version 0.7.0 milestone Jun 30, 2020
@hbldh hbldh self-assigned this Jun 30, 2020
Difference in availability of handles in BlueZ < 5.51.
@hbldh hbldh merged commit 545ed72 into develop Jun 30, 2020
@hbldh hbldh mentioned this pull request Jun 30, 2020
@geeksville
Copy link

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend: BlueZ Issues and PRs relating to the BlueZ backend Backend: Core Bluetooth Issues and PRs relating to the Core Bluetooth backend Backend: pythonnet Issues or PRs relating to the .NET/pythonnet backend bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants