Merge pull request spotbugs#898 from hazendaz/maven-api

[ci] Combine if statement
hazendaz · Oct 20, 2024 · 535da14 · 535da14
2 parents 78f47d0 + 913498b
commit 535da14
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy
@@ -91,23 +91,19 @@ final class ResourceHelper {
     private File getResourceAsFile(String name, String outputPath) {
         // Optimization for File to File fetches
         File f = FileResourceLoader.getResourceAsFile(name, outputPath, outputDirectory)
-
         if (f != null) {
             return f
         }
-
         // End optimization
 
         File outputResourceFile
 
         if (outputPath == null) {
             outputResourceFile = Files.createTempFile("plexus-resources", "tmp")
+        } else if (outputDirectory != null) {
+            outputResourceFile = new File(outputDirectory, outputPath)
         } else {
-            if (outputDirectory != null) {
-                outputResourceFile = new File(outputDirectory, outputPath)
-            } else {
-                outputResourceFile = new File(outputPath)
-            }
+            outputResourceFile = new File(outputPath)
         }
 
         try (InputStream is = new BufferedInputStream(resourceManager.getResourceAsInputStream(name))) {