v2 Refactor (BREAKING CHANGES) #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Namespace is not required anymore - ALB moved to it's own file - EFS moved into it's own file - ECR moved into it's own file - IAM instance profile name doesn't include namespace (only if it's part of `var.name`) - Cloudwatch ECS events name renamed (use `-` instead of `_`0 - Cluster name can't be inferred anymore (must be passed via parameter). Also is mandatory now. - ECR Repo name doesn't use namespace (only if it's included by the `var.name` - Docker image can be inferred from the ECR repo name (if managed) - EFS share creation separated from EFS share mount - Added ability to provide efs file system id explicitly (if it's not managed) - Bridgecrew tests removed (product discontinued) - Minor directory restructure - Variables ordering and updates - Minor reformatting & language updates - Precommit workflow added - Simple example added to README - Submodules README files added - Complete Examples updated - Added .editorconfig
- Upgrade cloudposse efs module to the latest 0.x.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
var.name)-instead of_0var.name