Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-380 Install tests #545

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Conversation

kobrikx
Copy link
Collaborator

@kobrikx kobrikx commented Nov 25, 2022

What's new:

  • added brew install test
  • added apt install test
Testing done:

Brew:
screenshot 2022-11-28 at 01 23 49

APT:
screenshot 2022-11-28 at 01 24 13

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #545 (0ca28ec) into main (fc11c48) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   30.55%   30.26%   -0.29%     
==========================================
  Files          64       64              
  Lines        8228     8310      +82     
==========================================
+ Hits         2514     2515       +1     
- Misses       5470     5549      +79     
- Partials      244      246       +2     
Impacted Files Coverage Δ
internal/commands/console.go 72.72% <0.00%> (-5.66%) ⬇️
internal/commands/tunnel_up.go 23.61% <0.00%> (-3.63%) ⬇️
internal/manager/serverless/native.go 57.98% <0.00%> (-1.17%) ⬇️
internal/commands/deploy.go 16.66% <0.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kobrikx kobrikx requested a review from AutomationD November 27, 2022 22:23
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Please adjust language/formatting that I've mentioned and please feel free to merge without additional review. 💪🏻

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kobrikx actually, is there any reason why we have two separate workflows? Why not use one workflow with two jobs (not matrix): Ubuntu, MacOS? If there is a reason, let's discuss, if there is no reason let's join them into one file run.install-tests.yml or something?

@AutomationD
Copy link
Contributor

Ok sounds good. Let's create a story to join the workflows in the future. Please put it in the backlog @kobrikx

@kobrikx kobrikx merged commit 87808e9 into main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants