Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistack example - vpc, s3 (ize-445) #517

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

kobrikx
Copy link
Collaborator

@kobrikx kobrikx commented Oct 25, 2022

What's new:

  • Added multitask monorepo

examples/multitask-monorepo/s3/s3.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all irrelevant pieces, and rebase.

examples/multitask-monorepo/main.tf Outdated Show resolved Hide resolved
examples/multitask-monorepo/vpc/main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please rebase to one commit then also let's have @igorkotof review.

@kobrikx kobrikx force-pushed the IZE-445-multistack-example-vpc-s-3 branch from 954c19a to a77d79a Compare October 27, 2022 13:43
@kobrikx kobrikx requested a review from AutomationD October 27, 2022 13:44
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@kobrikx kobrikx merged commit ac2527b into main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants