Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-514 allowed to view the text as is #508

Conversation

psihachina
Copy link
Contributor

Change:

allowed to view the text as is

Test:

asciicast

@psihachina psihachina requested a review from igorkotof October 19, 2022 14:45
Copy link
Contributor

@igorkotof igorkotof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AutomationD @psihachina what about to rename the flag to --full-plain-text-outputor just --plain-text-output
For me it's not clear what --plain-textmeans

@AutomationD
Copy link
Contributor

@AutomationD @psihachina what about to rename the flag to --full-plain-text-outputor just --plain-text-output

For me it's not clear what --plain-textmeans

I'm ok with plain-text-output.
It's more complex than just renaming. We need to make sure old parameter is not broken too.
@igorkotof feel free to create a story an we'll discuss the plan, if that's ok.

@psihachina psihachina force-pushed the IZE-514-able-to-disable-ux-and-print-colored-plain-text-instead branch 3 times, most recently from fe87e5b to 0bdf028 Compare October 20, 2022 16:47
@psihachina psihachina force-pushed the IZE-514-able-to-disable-ux-and-print-colored-plain-text-instead branch from 0bdf028 to c02c6d1 Compare October 20, 2022 16:55
@psihachina psihachina requested a review from igorkotof October 20, 2022 17:17
Copy link
Contributor

@igorkotof igorkotof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psihachina psihachina merged commit 04ed547 into main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants