Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-487 added display of possible properties when ize.toml has invalid syntax #493

Conversation

psihachina
Copy link
Contributor

Change:

added display of possible properties when ize.toml has invalid syntax

Test:

asciicast

@codecov-commenter
Copy link

Codecov Report

Merging #493 (96981be) into main (bb415b9) will increase coverage by 0.19%.
The diff coverage is 48.31%.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   30.81%   31.01%   +0.19%     
==========================================
  Files          60       60              
  Lines        7541     7629      +88     
==========================================
+ Hits         2324     2366      +42     
- Misses       4995     5038      +43     
- Partials      222      225       +3     
Impacted Files Coverage Δ
internal/commands/doc.go 11.86% <0.00%> (-23.14%) ⬇️
internal/schema/schema.go 76.25% <86.00%> (+14.95%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@igorkotof igorkotof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great feature!

@AutomationD
Copy link
Contributor

@kobrikx please assist @psihachina to make sure all e2e tests are green (cc @igorkotof )

@psihachina psihachina force-pushed the IZE-487-show-possible-properties-when-ize-toml-has-invalid-syntax branch from 96981be to cb78525 Compare October 13, 2022 07:51
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@psihachina psihachina merged commit 73b6f12 into main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants