Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IZE-581 Missing parameters showed at once #482

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

psihachina
Copy link
Contributor

Change:

added new jsonschema validator

Reson:

Old validator unsupported new drafts and bad handle errors.

Test:

asciicast

Old validator unsupported new drafts and bad handle errors.
@psihachina psihachina requested a review from igorkotof October 4, 2022 11:28
@codecov-commenter
Copy link

Codecov Report

Merging #482 (6e828fc) into main (9153744) will increase coverage by 0.11%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   29.87%   29.99%   +0.11%     
==========================================
  Files          60       60              
  Lines        7584     7535      -49     
==========================================
- Hits         2266     2260       -6     
+ Misses       5108     5066      -42     
+ Partials      210      209       -1     
Impacted Files Coverage Δ
internal/schema/schema.go 61.29% <85.00%> (+30.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@igorkotof igorkotof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psihachina psihachina merged commit 406d367 into main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants