Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IZE-511 changed generation of tfvars file taking into account ecs apps #469

Merged
merged 6 commits into from
Sep 23, 2022
Merged

IZE-511 changed generation of tfvars file taking into account ecs apps #469

merged 6 commits into from
Sep 23, 2022

Conversation

psihachina
Copy link
Contributor

Changelog:

  • changed generation of tfvars file taking into account ecs apps

Test:

asciicast

@codecov-commenter
Copy link

Codecov Report

Merging #469 (7f86ae4) into main (8c3d230) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   30.48%   30.49%   +0.01%     
==========================================
  Files          59       59              
  Lines        7349     7351       +2     
==========================================
+ Hits         2240     2242       +2     
  Misses       4905     4905              
  Partials      204      204
Impacted Files Coverage Δ
internal/commands/tfenv.go 83.94% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@psihachina psihachina force-pushed the IZE-511-dont-pass-docker-image-tag-to-variables-tfvars-when-ize-toml-doesnt-have-ecs branch from ccbc1ae to 4fb44fc Compare September 23, 2022 07:37
AutomationD
AutomationD approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@AutomationD AutomationD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed, otherwise looks good. Please fix it and feel free to merge.

internal/commands/down.go Outdated Show resolved Hide resolved
@psihachina psihachina force-pushed the IZE-511-dont-pass-docker-image-tag-to-variables-tfvars-when-ize-toml-doesnt-have-ecs branch from 9171a9e to 8ebc316 Compare September 23, 2022 15:15
@psihachina psihachina merged commit b278e0c into main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomationD AutomationD AutomationD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psihachina @codecov-commenter @AutomationD