Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add amd64 platform by default #455

Conversation

psihachina
Copy link
Contributor

@psihachina psihachina commented Sep 15, 2022

Changelog:

  • add amd64 platform by default

Tests:

image
image

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #455 (9e87c2f) into main (5a8df5b) will increase coverage by 6.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   21.63%   28.60%   +6.97%     
==========================================
  Files          50       51       +1     
  Lines        5426     5446      +20     
==========================================
+ Hits         1174     1558     +384     
+ Misses       4171     3766     -405     
- Partials       81      122      +41     
Impacted Files Coverage Δ
internal/commands/build.go 87.32% <ø> (ø)
internal/commands/ize.go 63.77% <100.00%> (-1.55%) ⬇️
internal/config/project.go 0.00% <0.00%> (ø)
internal/manager/alias/alias.go 100.00% <0.00%> (ø)
internal/commands/exec.go 62.83% <0.00%> (+46.31%) ⬆️
internal/commands/secrets_rm.go 72.34% <0.00%> (+53.59%) ⬆️
internal/commands/logs.go 69.47% <0.00%> (+54.47%) ⬆️
internal/commands/secrets_push.go 71.22% <0.00%> (+57.03%) ⬆️
internal/commands/secrets_pull.go 78.78% <0.00%> (+59.78%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is very useful

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expand help section of the prefer runtime flag.

@psihachina psihachina merged commit 63049ad into main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants