TOOLS-72 TOOLS-75 external tools validation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationD
requested changes
Oct 28, 2021
AutomationD
requested changes
Oct 30, 2021
internal/commands/base.go
Outdated
| //Check Docker and SSM Agent | ||
| _, err = CheckCommand("docker", []string{"info"}) | ||
| if err != nil { | ||
| return errors.New("docker is not running or is not installed") |
There was a problem hiding this comment.
Let's
- Capitalize Docker
- Provide a link to Docker download/install instructions.
There was a problem hiding this comment.
Also let's provide to ssm plug-in installation a link in the place where we notify user to install the plugin manually.
internal/commands/base.go
Outdated
|
|
||
| err = DownloadSSMAgentPlugin() | ||
| if err != nil { | ||
| return fmt.Errorf("download SSM Agent error: %v", err) |
There was a problem hiding this comment.
Let's capitalize Download
internal/commands/base.go
Outdated
|
|
||
| err = CleanupSSMAgent() | ||
| if err != nil { | ||
| return fmt.Errorf("cleanup SSM Agent error: %v", err) |
There was a problem hiding this comment.
Let's capitalize first letter
There was a problem hiding this comment.
| @@ -14,7 +14,7 @@ func (c *izeBuilderCommon) initConfig(filename string) (*config.Config, error) { | |||
| } | |||
|
|
|||
| if path == "" { | |||
| return nil, errors.New("A Waypoint configuration file (waypoint.hcl) is required but wasn't found.") | |||
| return nil, errors.New("an Ize configuration file (ize.hcl) is required but wasn't found") | |||
There was a problem hiding this comment.
Let's capitalize first letter
| @@ -23,7 +23,7 @@ func (c *izeBuilderCommon) initConfig(filename string) (*config.Config, error) { | |||
| func (c *izeBuilderCommon) initConfigPath(filename string) (string, error) { | |||
| path, err := config.FindPath(filename) | |||
| if err != nil { | |||
| return "", fmt.Errorf("Error looking for a Ize configuration: %s", err) | |||
| return "", fmt.Errorf("error looking for a Ize configuration: %s", err) | |||
There was a problem hiding this comment.
Is there a reason why we are switching to lowercase in the first word?
There was a problem hiding this comment.
internal/commands/helpers.go
Outdated
| if runtime.GOOS == "darwin" { | ||
| command = []string{"rm", "-rf", "sessionmanager-bundle sessionmanager-bundle.zip"} | ||
| } else if runtime.GOOS == "linux" { | ||
| command = []string{"rm", "-rf", "session-manager-plugin.rpm"} |
There was a problem hiding this comment.
Not sure if we need -r here, it's just a file
psihachina
force-pushed
the
TOOLS-72-external-tools-validation
branch
from
ba54234 to
3da92c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds:
Example:
Windows 11 SSM Agent
Ubuntu (wsl2) SSM Agent
Ubuntu (wsl2) Docker
Windows 11 Docker
Not tested on MasOS