This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Support of enforced AWS MFA #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igorkotof
commented
Sep 24, 2021
•
igorkotof
commented
- Makefile requires to have AWS_MFA_ENABLED variable (true or false)
- After execution of local script for getting MFA session token you will be able to use ICMK targets which use AWS CLI
AutomationD
suggested changes
Sep 27, 2021
| # Macroses | ||
| ######################################################################################################################## | ||
| # We don't check for AWS_PROFILE, but instead we assume the profile name. | ||
| # You can override it, although it's recommended to have a profile per environment in your ~/.aws/credentials | ||
| AWS_PROFILE ?= $(NAMESPACE)-$(ENV) | ||
| AWS_CLI_PROFILE ?= $(shell echo $$(if [ "$(AWS_MFA_ENABLED)" = "true" ]; then echo ""; else echo "--profile $(AWS_PROFILE)"; fi)) |
There was a problem hiding this comment.
Do you think this should be reflecting the MFA nature? like AWS_PROFILE_MFA?
There was a problem hiding this comment.
@AutomationD I do not think so since if we use MFA - there is no needs in AWS Profile, thoughts?
There was a problem hiding this comment.
Okay, sounds good. Let's keep it as is.
AutomationD
approved these changes
Oct 4, 2021
| # Macroses | ||
| ######################################################################################################################## | ||
| # We don't check for AWS_PROFILE, but instead we assume the profile name. | ||
| # You can override it, although it's recommended to have a profile per environment in your ~/.aws/credentials | ||
| AWS_PROFILE ?= $(NAMESPACE)-$(ENV) | ||
| AWS_CLI_PROFILE ?= $(shell echo $$(if [ "$(AWS_MFA_ENABLED)" = "true" ]; then echo ""; else echo "--profile $(AWS_PROFILE)"; fi)) |
There was a problem hiding this comment.
Okay, sounds good. Let's keep it as is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.