Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

ecs task fail was added #151

Merged
merged 4 commits into from
Jun 21, 2021
Merged

ecs task fail was added #151

merged 4 commits into from
Jun 21, 2021

Conversation

gloovers
Copy link
Contributor

@gloovers gloovers commented Jun 20, 2021

Description

There were made changes to AWS ECS Task logic:

  1. make waits till task completion
  2. Once one of task's containers is failed (exit code is not zero) make macros execution will have fail status

Tests

Test Cases

  1. Task is competed with containers exit code 0 (successfully)
    asciicast
  2. Task is completed with non zero exit code
    asciicast

@github-actions
Copy link

github-actions bot commented Jun 20, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   31s ⏱️ ±0s
9 tests ±0  9 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6af8282. ± Comparison against base commit 6af8282.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor naming recommendations.

aws/ecs.mk Outdated Show resolved Hide resolved
aws/ecs.mk Outdated Show resolved Hide resolved
@gloovers gloovers requested a review from AutomationD June 21, 2021 06:46
@gloovers gloovers merged commit 6af8282 into master Jun 21, 2021
@gloovers gloovers deleted the feature/ecs-task-status branch June 21, 2021 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants