This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
part of docker containers should run with non root user #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkotof
reviewed
Apr 8, 2021
| @@ -44,7 +57,6 @@ terraform.debug: | |||
| terraform.init: gomplate terraform | |||
| @ \ | |||
| cd $(ENV_DIR) && \ | |||
| mkdir -p $(ENV_DIR)/.terraform && \ | |||
There was a problem hiding this comment.
we should remove this row since running terraform container with non-root user create .terraform folder with correct permission
@kobrikx ?
There was a problem hiding this comment.
Seems like this should be safe to remove
AutomationD
approved these changes
Apr 9, 2021
igorkotof
approved these changes
May 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of containers should run with non-root user
Tests
covered within unit-tests