Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Work with SSM via wrapper #119

Merged
merged 8 commits into from
Feb 3, 2021
Merged

Work with SSM via wrapper #119

merged 8 commits into from
Feb 3, 2021

Conversation

igorkotof
Copy link
Contributor

@igorkotof igorkotof commented Jan 25, 2021

Based on https://github.com/isabey-cogni/ssm-wrapper:

  • Added list functionality
  • Added push functionality
  • delete functionality should be fixed via PR to the opensource project (I've already checked the code - it should be easy)

Testing:
asciicast

@igorkotof igorkotof requested a review from AutomationD January 25, 2021 20:21
@igorkotof
Copy link
Contributor Author

Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to have a separate command for this? I'm curious.

@igorkotof
Copy link
Contributor Author

Do we really need to have a separate command for this? I'm curious.

@AutomationD no, it's just to show and for testing - if you like it - I will update with deleting old command

@AutomationD
Copy link
Contributor

Do we really need to have a separate command for this? I'm curious.

@AutomationD no, it's just to show and for testing - if you like it - I will update with deleting old command

Ah, makes sense.

@igorkotof could you please give more overview of which tool are we using, maybe post a link in the PR text?

@igorkotof
Copy link
Contributor Author

Do we really need to have a separate command for this? I'm curious.

@AutomationD no, it's just to show and for testing - if you like it - I will update with deleting old command

Ah, makes sense.

@igorkotof could you please give more overview of which tool are we using, maybe post a link in the PR text?

@AutomationD I've added

@AutomationD
Copy link
Contributor

Do we really need to have a separate command for this? I'm curious.

@AutomationD no, it's just to show and for testing - if you like it - I will update with deleting old command

@igorkotof So, what's the plan with global secrets?

@igorkotof igorkotof requested a review from AutomationD January 29, 2021 22:14
@igorkotof
Copy link
Contributor Author

Do we really need to have a separate command for this? I'm curious.

@AutomationD no, it's just to show and for testing - if you like it - I will update with deleting old command

@igorkotof So, what's the plan with global secrets?

@AutomationD keep like $(INFRA_DIR)/env/$(ENV)/secrets/global.json

@igorkotof igorkotof changed the title WIP: Work with SSM via wrapper Work with SSM via wrapper Feb 1, 2021
aws/secrets.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

aws/secrets.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ensure we've done final tests with all current changes.
Otherwise it looks good to me, thank you!

@igorkotof igorkotof merged commit 6266bdb into master Feb 3, 2021
@igorkotof igorkotof deleted the feature/ssm-wrapper branch February 3, 2021 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants