Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Resolve symlinks in PROJECT_PATH #117

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Resolve symlinks in PROJECT_PATH #117

merged 2 commits into from
Jan 28, 2021

Conversation

russmac
Copy link
Contributor

@russmac russmac commented Jan 23, 2021

Resolve issues with Docker lstat calls on symlinks

Makefile

CUT=cut
SVC = $(shell echo $(@) | $(CUT) -d. -f1 )
PROJECT_PATH ?= $(shell cd projects/$(SVC) && pwd -P)

foo:
	@echo $(SVC)
	@echo $(PROJECT_PATH)
$ make foo
foo
/home/redacted/redacted/maketest/projects/bar
$ ls -al projects/foo
lrwxrwxrwx 1 redacted redacted 3 Jan 23 14:03 projects/foo -> bar

@russmac russmac requested a review from AutomationD January 25, 2021 03:06
Copy link
Contributor

@AutomationD AutomationD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

I think ideally we should start adding some tests (and run them across multiple platforms).

But I am not sure which testing framework should we use.

@russmac russmac merged commit 218d90d into hazelops:master Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants