Add required tags and update VPC/IGW related to AWS account migration #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to aws account migration
|
|
gbarnett-hz
requested changes
Dec 4, 2024
gareth-johnston
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good to me, just need to address @gbarnett-hz comment
gbarnett-hz
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim of this PR is to adapt hazelcast-simulator into new AWS account migration requirements. As a result team/type tags are added into related resources created by hazelcast-simulator and VPC/IGW details are updated with new values. After the changes, I created sample infrastructure, tested with sample test and observed that resources are created under new account with required tags and networking configuration.