Add setting logging level and building custom docker images #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwart
reviewed
Apr 1, 2019
hazelcast-enterprise/Dockerfile
Outdated
|
|
||
| # Install | ||
| RUN echo "Updating Alpine system" \ | ||
| && apk add --no-cache nss \ |
There was a problem hiding this comment.
Could you move just the nss 3 lines down to another apk add?
| # can be overriden by a facility specific level | ||
| # Note that the ConsoleHandler also has a separate level | ||
| # setting to limit messages printed to the console. | ||
| .level= INFO |
There was a problem hiding this comment.
Duplicating keys in property files can be confusing. We should either have the logging.properties without the keys and append them when starting container or we should simply substitute the existing values (sed).
| @@ -84,6 +84,16 @@ $ docker run -e MANCENTER_URL=<mancenter_url> hazelcast/hazelcast-enterprise | |||
|
|
|||
| The port of the JMX Prometheus agent. For example, if you set `PROMETHEUS_PORT=8080`, then you can access metrics at: `http://<hostname>:8080/metrics`. You can also use `PROMETHEUS_CONFIG` to set a path to the custom configuration. | |||
|
|
|||
| ### LOGGING_LEVEL | |||
|
|
|||
| The logging level can be changed using the `LOGGING_LEVEL` variable, for example, to see the `FINEST` logs. | |||
There was a problem hiding this comment.
Could we list possible values here or add a link to the Level class JavaDoc?
|
@kwart Thanks for the review. I addressed your comments. PTAL. |
kwart
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
logging.propertiesfileLOGGING_LEVELto enable changing logging level while starting the containerapk add --no-cache nss(unrelated, but needed because of the change in Alpine, read more here)fix #108