Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-1328] Fix ${serviceName} property which references to empty string #437

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

semihbkgr
Copy link
Contributor

Fixes #436

Create a new map for the Hazelcast configuration to ensure that conflicting Kubernetes discovery configuration fields are removed while preserving the value of serviceName.

@semihbkgr semihbkgr marked this pull request as ready for review July 30, 2024 12:56
Copy link
Contributor

@kutluhanmetin kutluhanmetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it is working, I think we can merge it.

@devOpsHazelcast
Copy link

PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions

@kutluhanmetin kutluhanmetin merged commit e1b0125 into master Nov 13, 2024
4 checks passed
@kutluhanmetin kutluhanmetin deleted the cn-1328 branch November 13, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service-dns substitutes ${serviceName} with empty string
4 participants