Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backport PR success comment PR link #21

Conversation

JackPGreen
Copy link
Contributor

Adds a direct link (as a comment) to the new backported PR.

Adds a direct link (as a comment) to the new backported PR
@JackPGreen JackPGreen requested a review from ldziedziul January 21, 2025 22:50
@JackPGreen JackPGreen self-assigned this Jan 21, 2025
@JackPGreen JackPGreen mentioned this pull request Jan 21, 2025
Copy link
Collaborator

@ldziedziul ldziedziul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackPGreen JackPGreen merged commit 5e3b736 into hazelcast:master Jan 21, 2025
3 checks passed
JackPGreen added a commit to JackPGreen/backport that referenced this pull request Jan 22, 2025
A [syntax error causes a failure to evaluate the script](https://github.com/hazelcast/hz-docs/actions/runs/12912238050).

This was _probably_ a copy-paste error introduced when copying from my test environment in hazelcast#21
@JackPGreen JackPGreen mentioned this pull request Jan 22, 2025
JackPGreen added a commit that referenced this pull request Jan 23, 2025
A [syntax error causes a failure to evaluate the
script](https://github.com/hazelcast/hz-docs/actions/runs/12912238050).

This was _probably_ a copy-paste error introduced when copying from my
test environment in #21.

I have investigated some kind of validation tool to catch this error to
add to the PR builder without running the workflow but been
unsuccessful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants