-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Adds HTML markdown preview below notes editor. #16
Conversation
Cool! Markdown saving and updating works great. A few small comments. 1. Dragging the notes textarea can cover the markdown.Should they be put in a flex box or something so they don't overlap? 2. Setting CSS textarea height to 100% causes a layout issue in the tags tab.3. Does adding this external dependency cause a noticeable loading delay on first load of the model manager?On my end I think I noticed a (painful) second delay. Can this be avoided? |
Thanks for the rapid feedback. I was considering some html to md converters like showdown so formatting is preserved a little better. Would that be of interest vs the nested replace statements? I was struggling to import it due to it being nodejs...and my js skills are a bit out of date :) |
Sure, the html-to-md replace statements were a quick solution to avoid an import, but they can be removed if you can avoid user delay. I'm not super experienced with JS, so no pressure. |
- pulled ESM modules for local loading. - added downshow module for better HTML to MD conversion.
@hayden-fr all issues raised in screen shots and comments should be resolved. Did a little bit of linting as I went. Also cleaned up the tags view. I think that was there prior to my change, but should be better now. Love this extension. It's a real game changer. |
I tested it again and it works great. The toggle is a great idea. One minor thought. For consistency and maximum space on small screens, should the top row, textarea and markdown elements be flat so the three elements scroll together? Unless you think it is more convenient as it is for easy access to the save button. (And yeah, this extension is super important to me in order to keep notes on how to use a model and which ones work. That said, there will likely be a built-in solution within the next year given the changes in the UI. However, before then, I'd like to rebuild it as a general file manager, but I couldn't figure out how to import or use Vue/Vuetify.) |
Okay, it looks good to me. @hayden-fr |
Uses marked javascript library to provide an HTML formatted view below the markdown textarea editor. Updates the preview when textarea changes are saved.