Enhance node container (Closes #25) #73
Conversation
|
Oops, forgot about that. Feel free to merge at your discretion ;) |
|
This is so old I don't even remember if it works. @mikicho maybe you can have a try? |
|
Also this should fix #96, summon @gene-pavlovsky |
|
@kevinresol |
# Conflicts: # src/tink/http/containers/NodeContainer.hx
|
@gene-pavlovsky see if it works now |
|
Thanks. I'll try it on weekend. |
|
@kevinresol @gene-pavlovsky |
| }); | ||
| } | ||
|
|
||
| if(untyped server.listening) // .listening added in v5.7.0, not added to hxnodejs yet |
There was a problem hiding this comment.
If you dare to use the github version of hxnodejs:
HaxeFoundation/hxnodejs#104 (comment)
There was a problem hiding this comment.
Great, but I think I will keep it as-is until hxnodejs got a proper release. So not to frustrate tink_http users.
There was a problem hiding this comment.
Sure, makes sense. I still haven't got time to test my project with this.
|
Let's move ahead, and break it fast =P |
Closes #25