fix(util): make intrusive list links never Unpin #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iximeow
approved these changes
Mar 28, 2021
In light of rust-lang/rust#82834, we must ensure that the intrusive linked list pointers never get mutable-noalias optimizations (see also rust-lang/rust#63818). Adding a `PhantomPinned` to the `Links` struct ensures it will always be `!Unpin`, disabling mutable-noalias. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/never-unpin-ptrs
branch
from
fae54bc
to
7df5ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of rust-lang/rust#82834, we must ensure that the intrusive
linked list pointers never get mutable-noalias optimizations (see also
rust-lang/rust#63818). Adding a
PhantomPinnedto theLinksstructensures it will always be
!Unpin, disabling mutable-noalias.Signed-off-by: Eliza Weisman [email protected]