platform mods1 #45
Open
platform mods1 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump? |
jrbinks
force-pushed
the
clogin-platform-mods1
branch
from
8c25a35 to
dc410ac
Compare
…ncid-strdev into clogin-platform-mods1 * 'clogin-platform-mods1' of https://github.com/jrbinks/rancid-strdev: Fix duplication in a10login.in platform hint addition to all login scripts using login_top
…ncid-strdev into clogin-platform-mods1 * 'clogin-platform-mods1' of https://github.com/jrbinks/rancid-strdev: Fix duplication in a10login.in platform hint addition to all login scripts using login_top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my comment on mailing list https://www.shrubbery.net/pipermail/rancid-discuss/2022-January/011154.html here's a branch which incorporates my platform hint option into all the login scripts that have been modified to use login_top.
Many platforms won't need this, but it opens up some possibilities, maybe helps take us down a road of being able to unify at least some of the login scripts; and I have a use case for it in another submission so I would like to see it in the main release. I need to do some extra things for a variant of comware, so need to supply the hint to the login script to signal that - it may not be possible to auto-detect this variant behaviour, like clogin currently does for ExtremeXOS (I think, although I have doubts about how that works too).