Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added remote and multiple file fetch to sync #405

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

zackbradys
Copy link
Member

@zackbradys zackbradys commented Feb 5, 2025

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Feature

Proposed Changes:

  • Updated hauler store sync to be able to accept remote files and multiple files
    • with hauler store sync --filename hauler-manifest1.yaml --filename hauler-manifest2.yaml
  • Updated associated code and logs to account for the changes
  • Updated the default manifest name to hauler-manifest.yaml

Verification/Testing of Changes:

  • Passed all unit and integration tests...

Additional Context:

@zackbradys zackbradys self-assigned this Feb 5, 2025
@zackbradys zackbradys added enhancement New feature or request size/M Denotes an issue/PR requiring a relatively moderate amount of work labels Feb 5, 2025
@zackbradys zackbradys added this to the Hauler v1.2.0 milestone Feb 5, 2025
@zackbradys zackbradys linked an issue Feb 5, 2025 that may be closed by this pull request
@zackbradys zackbradys requested a review from a team February 5, 2025 07:24
amartin120
amartin120 previously approved these changes Feb 5, 2025
Copy link
Contributor

@amartin120 amartin120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackbradys zackbradys dismissed amartin120’s stale review February 5, 2025 13:58

The merge-base changed after approval.

@zackbradys zackbradys merged commit 3932558 into hauler-dev:main Feb 5, 2025
1 of 2 checks passed
@zackbradys zackbradys deleted the sync-remote-updates branch February 5, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes an issue/PR requiring a relatively moderate amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

[feature] Allow hauler to load and sync remote files
2 participants