Enhance EHCI

[hathach]

Describe the PR

• Fix issue with hub status_change is not aligned
• EHCI use standard USB complete interrupt instead of custom chipidea async/period interrupt to be more compatible with other ehci implementation
• refactor usb complete & error isr processing, merge, update. Should probably fix EHCI QHD reuses QTD on wrong endpoint #2166 . @tannewt please try it out when you have time.

[tannewt]

I think this is needed to write the detach values back to RAM:

// Remove an attached TD from queue head
static void qhd_remove_qtd(ehci_qhd_t *qhd) {
  ehci_qtd_t * volatile qtd = qhd->attached_qtd;

  qhd->attached_qtd = NULL;
  qhd->attached_buffer = 0;
  hcd_dcache_clean(qhd, sizeof(ehci_qhd_t));

  qtd->used = 0; // free QTD
  hcd_dcache_clean(qtd, sizeof(ehci_qtd_t));
}

[hathach]

I think this is needed to write the detach values back to RAM:

It may not be needed, since these are all software only field for managing driver accessed by CPU only. EHCI controller does know/need to access these values at all. Let me know ifthis PR help with your issue

[tannewt]

I think this is needed to write the detach values back to RAM:

It may not be needed, since these are all software only field for managing driver accessed by CPU only. EHCI controller does know/need to access these values at all. Let me know ifthis PR help with your issue

They are software only but you invalidate the cache for QHD and QTD because there is data on the same cache line that the EHCI controller needs. That drops any values written to the cache but not RAM. So, you need to clean when writing QTD or QHD because you may invalidate it later.

[hathach]

Indeed, you are right, I am updating PR with suggested changes :)