Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movement of TOP in c0ecf8b5 broke RP2040 SDK build #2100

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

kilograham
Copy link
Collaborator

not sure how this would have worked for any of the others either

@kilograham kilograham requested a review from hathach June 7, 2023 19:47
@hathach
Copy link
Owner

hathach commented Jun 8, 2023

should be no issue, though I found that for cmake, we don't need TOP to be absolute path as with makefile. Do pi example requires TOP to be absolute to build ?

@kilograham
Copy link
Collaborator Author

kilograham commented Jun 9, 2023

should be no issue, though I found that for cmake, we don't need TOP to be absolute path as with makefile. Do pi example requires TOP to be absolute to build ?

Well you changed TOP from ${CMAKE_CURRENT_LIST_DIR}/../../.. to ${CMAKE_CURRENT_LIST_DIR}/../.. when you moved it to the parent family_support.cmake.

All the uses are a directory deeper ${TOP}/some_file which no longer match up. I figured if you wanted TOP to be usable anywhere in that sub-tree I'd make it absolute. Otherwise you could have left it as ${CMAKE_CURRENT_LIST_DIR}/../../.. but that would seem a bit weird

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr, sorry, I didn't notice this would break pi examples.

@hathach hathach merged commit 39a6433 into hathach:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants