Vendor device race condition fix #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sample updated that I missed earlier. It should pass the gated build now. |
|
Trailing whitespace removed that cause the pre-commit to fail. The rest passed. |
HiFiPhile
approved these changes
Apr 1, 2023
hathach
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
look good, thank you. There is quite of duplication code for driver with stream/buffered endpoint. I have added tu_edpt_stream (read/write) API. In the future we will migrate to those instead
https://github.com/hathach/tinyusb/blob/master/src/common/tusb_private.h#L124
currently only cdc host used this stream edpt https://github.com/hathach/tinyusb/blob/master/src/class/cdc/cdc_host.c#L61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use usbd_edpt_claim, usbd_edpt_release in vendor device class
An issue similar to #1470 was discovered in my testing on a PCA10059 running MyNewt/Nimble. This PR ports over the use of the endpoint claim and release mechanisms used in the cdc class, which seems similar. This resolved the race condition I encountered that would result in IN transfers getting stuck until the next OUT transfer was started.