Adjust reserved bitfields to make SDCC happy #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep each field at or under 16b - For optimal packing, segment fields to 8b boundaries
hathach
reviewed
Feb 13, 2023
src/class/cdc/cdc.h
Outdated
| uint32_t TU_RESERVED : 26; | ||
| uint32_t TU_RESERVED0 : 2; | ||
| uint32_t TU_RESERVED1 : 16; | ||
| uint32_t TU_RESERVED2 : 4; |
There was a problem hiding this comment.
2+16+4 = 22, last one should be 8
There was a problem hiding this comment.
How embarrassing! I changed it at the last minute and got it wrong :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open-source SDCC compiler has many limitations, but I have managed, after considerable hacking, to compile TinyUSB with it. This is one issue that I think is legitimately universal: compiler-specific assumptions about bitfield alignment which are implementation-defined per the Standard. Please see the discussion with the SDCC maintainers.
Describe the PR
This PR tweaks some reserved bitfields so the assumptions made elsewhere in the code (particularly in an assert) are more portable, and so they hew to implementation-defined limits on size. In particular:
Additional context
N/A
If merged this will resolve #1892