fix: Replace device calls to memcpy with tu_memcpy_s #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-brough
force-pushed
the
mem_s
branch
7 times, most recently
from
25ec4e3 to
326cca5
Compare
Introduces a new function tu_memcpy_s, which is effectively a backport of memcpy_s. The change also refactors calls to memcpy over to the more secure tu_memcpy_s.
nathaniel-brough
force-pushed
the
mem_s
branch
from
326cca5 to
2e47210
Compare
hathach
reviewed
Feb 27, 2023
| @@ -707,7 +707,7 @@ static int32_t proc_builtin_scsi(uint8_t lun, uint8_t const scsi_cmd[16], uint8_ | |||
| read_capa10.block_size = tu_htonl(block_size); | |||
|
|
|||
| resplen = sizeof(read_capa10); | |||
| memcpy(buffer, &read_capa10, (size_t) resplen); | |||
| TU_VERIFY(tu_memcpy_s(buffer, bufsize, &read_capa10, (size_t) resplen)); | |||
hathach
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
superb !! Thank you very much for the PR and sorry again for the delay. memcpy_s is a great idea to prevent memory overflow, this function is new to me. I found an instance where ==0 is not checked, to prevent such as typo, I have change the code to 0==tu_memcpy_s(), this way it is easier to spot this type of issue.
Thank again for bringing this up.
|
No worries 👍 |
|
For UAC class tinyusb/src/class/audio/audio_device.c Line 2293 in 34798ff I'm in vacation anyone can make a PR ? @silvergasp @hathach |
|
PR here #1937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Introduces a new function tu_memcpy_s, which is effectively a backport of memcpy_s. The change also refactors calls to memcpy over to the more secure tu_memcpy_s.
More specifically, this change adds some bounds checking to the destination buffer, to prevent buffer overflows.
What this PR cover's;
What this PR doesn't cover;